On Tue, 30 Jan 2024 14:02:41 GMT, Matthias Baesken <[email protected]> wrote:
>>> Yes there is a nice define in the AIX header
>>
>> *sigh* On linux, they go to some lengths to avoid this, using a __REDEFINE
>> mechanism. Oh well.
>>
>> Anyway, I think this particular can be resolved by not including the
>> standard includes in the header file (which is bad practice anyway!). I'm
>> currently testing this build in our CI to see that it does not break
>> anything else. I'd appreciate if you could take the latest version for a
>> spin, particularly a debug build...
>
>> I'd appreciate if you could take the latest version for a spin, particularly
>> a debug build...
>
> Yes we pick up the latest version of the PR in a couple of hours for the
> build+'lots of tests' (and this includes a fastdebug too).
@MBaesken, @JoKern65: This seems to break the debug build (fast and slow) on
AIX:
jdk/src/java.desktop/share/native/libawt/java2d/pipe/BufferedRenderPipe.c:101:24:
error: no member named 'open64' in 'SpanIteratorFuncs'; did you mean 'open'?
srData = (*pFuncs->open)(env, si);
^~~~
open
/usr/include/fcntl.h:115:14: note: expanded from macro 'open'
#define open open64
^
jdk/src/java.desktop/share/native/libawt/java2d/pipe/SpanIterator.h:37:17:
note: 'open' declared here
void *(*open)(JNIEnv *env, jobject iterator);
^
Ah, that has already been reported above. Yeah, interesting that the normal
build has passed.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17538#issuecomment-1918443702
