Re: RFR: JDK-8325189: Enable this-escape javac warning in java.base

[Daniel Fuchs]

On Tue, 6 Feb 2024 17:29:25 GMT, Joe Darcy <da...@openjdk.org> wrote:

>> src/java.base/share/classes/sun/net/www/MessageHeader.java line 53:
>> 
>>> 51:     }
>>> 52: 
>>> 53:     @SuppressWarnings("this-escape")
>> 
>> An alternative here could be to make the class final. AFAICS it's not 
>> subclassed anywhere. If you'd prefer not to do this here then maybe a 
>> followup issue could be logged?
>
> I'd prefer if that kind of change were done as a subtask of
> 
> [JDK-8325263](https://bugs.openjdk.org/browse/JDK-8325263): Address 
> this-escape lint warnings java.base (umbrella)

Thanks Joe. I logged 
[JDK-8325361](https://bugs.openjdk.org/browse/JDK-8325361): Make 
sun.net.www.MessageHeader final

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17692#discussion_r1480362736