On Fri, 23 Feb 2024 21:40:22 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

>> There is not much overlap on how linking is done on Windows on one hand, and 
>> on all Unix platforms on the other. This makes Link.gmk basically consists 
>> of two parts, each in it own half of if statements, and the few common parts 
>> are artificially shoehorned in to fit both sides.
>> 
>> The code will be much clearer if we just split this into two different files.
>> 
>> Note that this PR slightly collides with JDK-8326583 
>> (https://github.com/openjdk/jdk/pull/17986). Whichever of this goes in first 
>> will mean that the other one needs to make some adaptations.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Rename Windows to Microsoft

I think this looks good. There looks to be a conflict with 
https://github.com/openjdk/jdk/pull/17986, but I assume you are aware.

make/autoconf/flags-other.m4 line 45:

> 43: AC_DEFUN([FLAGS_SETUP_LIBFLAGS],
> 44: [
> 45:     # LIB is used to create static libraries on Windows

indentation.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17987#pullrequestreview-1899019687
PR Review Comment: https://git.openjdk.org/jdk/pull/17987#discussion_r1501222826

Reply via email to