On Fri, 8 Mar 2024 15:41:16 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert SEARCH_PATH changes > > make/autoconf/toolchain.m4 line 444: > >> 442: COMPILER_NAME=$2 >> 443: SEARCH_LIST="$3" >> 444: SEARCH_PATH="$PATH" > > I am note 100% sure about this; I think the intention of some of the old code > amounted to this, but it was not entirely clear. > > But, then again, I think this is a good idea, and I think we should do this > on *all* platforms -- search the toolchain path before the normal path. Hm, as I write this, it strikes me as odd that we should not do this already. And of course we do, in `TOOLCHAIN_PRE_DETECTION`, so this snippet snippet is actually redundant. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18172#discussion_r1517889315
