On Wed, 13 Mar 2024 09:11:23 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

>> After we removed mapfiles, we can setup -fvisibility=hidden (and 
>> -Wl,--exclude-libs,ALL) in the most basic flags, so this applies to all 
>> compilation.
>> 
>> This will remove duplicate code and make the underlying assumptions of the 
>> build clearer.
>> 
>> Doing this will result in the same output result -- with one exception: 
>> native test libraries has not been compiled with this flag (and this caused 
>> an error for a Oracle-internal test).
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to 
> a merge or a rebase. The pull request now contains five commits:
> 
>  - Merge branch 'master' into visibility-hidden-everywhere
>  - Merge branch 'master' into visibility-hidden-everywhere
>  - 8327045: Consolidate -fvisibility=hidden as a basic flag for all 
> compilation
>  - Update line number for dereference_null  in TestDwarf
>  - 8327460: Compile tests with the same visibility rules as product code

This PR has just become too messy. I'll close it and open a new.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18061#issuecomment-1993988370

Reply via email to