On Wed, 20 Mar 2024 06:44:02 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> Sorry, I don't see a BOOL error anywhere? > > I see the advantage of collapsing self and parent into the same check, but it > doesn't seem like getting rid of pData is of much benefit, the checks for > null seem to remain the same either way > Sorry, I don't see a BOOL error anywhere? I think Phil misplaced the code block marker -- the BOOL error line and below is supposed to be inside the second code block. What Phil is doing is trying to suggest two different approaches to make this code nicer, the first with a bit more duplication, and the second with an `error` boolean flag. And he says that he prefers the former, so the second were propably just mentioned to show an alternative for discussion. I think what you should do here is to combine the `self` and `parent` null checks as Phil suggests. And then replace all pData references to the final variable, here as well as everywhere pData is involved. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1540025427
