On Tue, 26 Mar 2024 16:18:43 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> This is a follow-up on JDK-8328680, making the same kind of cleanup to > jdk.jpackage. The code here needed more work than for the other modules, so I > wanted have it in a separate PR to get a more thorough review. Marked as reviewed by erikj (Reviewer). make/common/JdkNativeCompilation.gmk line 294: > 292: $$($1_EXTRA_RCFLAGS) > 293: > 294: ifneq ($$($1_HEADERS_FROM_SRC), false) I note that this parameter in SetupJdkLibrary is documented in the comment above the definition, but you haven't added any of the new parameters to SetupJdkExecutable to the comment for that macro. Should we, or is the intention to rework this file anyway? ------------- PR Review: https://git.openjdk.org/jdk/pull/18491#pullrequestreview-1961795710 PR Review Comment: https://git.openjdk.org/jdk/pull/18491#discussion_r1540146998
