On Fri, 29 Mar 2024 07:19:33 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> src/hotspot/os/aix/loadlib_aix.cpp line 120:
>>
>>> 118: (lm->is_in_vm ? '*' : ' '),
>>> 119: (uintptr_t)lm->text, (uintptr_t)lm->text + lm->text_len,
>>> 120: (uintptr_t)lm->data, (uintptr_t)lm->data + lm->data_len,
>>
>> Please don't cast, use `p2i()`.
>
> Check copyrights in this file and all others. Adapt SAP and Oracle copyrights.
Done + will adopt copyrights
>> src/hotspot/os/aix/os_aix.cpp line 651:
>>
>>> 649: lt.print("Thread is alive (tid: " UINTX_FORMAT ", kernel thread
>>> id: " UINTX_FORMAT
>>> 650: ", stack [" PTR_FORMAT " - " PTR_FORMAT " (" SIZE_FORMAT
>>> "k using %luk pages)).",
>>> 651: os::current_thread_id(), (uintx) kernel_thread_id,
>>> (uintptr_t)low_address, (uintptr_t)high_address,
>>
>> Use p2i, not cast
>
> Here, and in other places too where you cast a pointer to fit into PTR_FORMAT
> or INTPTR_FORMAT
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18536#discussion_r1547607793
PR Review Comment: https://git.openjdk.org/jdk/pull/18536#discussion_r1547606610
