On Wed, 8 May 2024 13:30:59 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> As seen in [JDK-8331541](https://bugs.openjdk.org/browse/JDK-8331541), if we > are not consistently setting all assembler directives correctly, we can get > errors that are not detected by the linker. > > We should stop duplicating this code and create a unified macro to properly > setup functions, and use it everywhere. This pull request has now been integrated. Changeset: cabe3374 Author: Magnus Ihse Bursie <i...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/cabe337400a0bd61d73bf3ca66e16266267299c7 Stats: 604 lines in 22 files changed: 124 ins; 347 del; 133 mod 8331921: Hotspot assembler files should use common logic to setup exported functions Reviewed-by: coleenp, erikj, dholmes ------------- PR: https://git.openjdk.org/jdk/pull/19138