On Wed, 12 Jun 2024 06:43:15 GMT, Thomas Stuefe <[email protected]> wrote:
>> Sonia Zaldana Calles has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixing optional group to work with bsd as well
>
> make/scripts/update_copyright_year.sh line 70:
>
>> 68: echo "y Specifies the copyright year. Set to current year by
>> default."
>> 69: echo "h Print this help."
>> 70: echo "f Updates all change sets in a full year."
>
> - Please specify the leading dash on all options
> - I would print "y" after "f" and write something along these lines "If -f is
> specified, defines the year of changes for which to modify the copyright
> (current year if omitted)"
Hi Thomas,
I assume with this we hope to clarify what time period of changes we are
addressing with `-f`. Would something like this communicate what you suggested?
Usage: update_copyright_year.sh [-c company] [-y year] [-h|f]
options:
-c Specifies the company. Set to Oracle by default.
-y Specifies the copyright year. Set to current year by default.
-f Updates the copyright for all change sets in a given year,
as specified by -y.
-h Print this help.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19605#discussion_r1636490568
