On Tue, 25 Jun 2024 18:55:14 GMT, Robert Toyonaga <[email protected]> wrote:
> This PR changes GenerateJfrFiles.java so that the generated > `JfrNativeSettings` union does not include JFR structs.`JfrNativeSettings` is > meant to hold the settings for JFR events, but previously also included JFR > structs such as MetaspaceSizes, StackFrame, CopyFailed, > G1EvacuationStatistics, ObjectSpace, VirtualSpace. These are not events, but > instead are JFR `Type`s, and so do not have settings such as stacktraces or > thresholds. > > The inclusion of JFR structs in `JfrNativeSettings` was problematic because > it could cause a displacement between event ID and`JfrNativeSettings` array > index (each index is meant to correspond with a specific event ID). > > Testing: > - jdk/jdk/jfr > - tier1 This pull request has now been integrated. Changeset: da0ffa8b Author: Robert Toyonaga <[email protected]> Committer: Thomas Stuefe <[email protected]> URL: https://git.openjdk.org/jdk/commit/da0ffa8b7ff04eb5cbc0fcbe4b858f20d7e46405 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8334031: Generated JfrNativeSettings seems off Reviewed-by: egahlin ------------- PR: https://git.openjdk.org/jdk/pull/19891
