On Sat, 13 Jul 2024 13:43:42 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:

> In [JDK-8257913](https://bugs.openjdk.org/browse/JDK-8257913), we added the 
> search paths for X11 libraries, but they point explicitly to `libX11.so`. 
> First, this is not really correct, as `x_libraries` would be added to a 
> search path. Second, this apparently does not work for sysroots created by 
> crosstool-ng, likely because it wants to find other libraries in the same 
> location. Debootstrap-ed GHA seem to work because they find the X11 libraries 
> before hitting this code, apparently.
> 
> We should just drop the `libX11.so` parts, and leave only the path.
> 
> Additional testing:
>  - [x] JDK 23, 21, 17, 11 builds with the patch and crosstool-ng without 
> problems now
>  - [x] GHA
>  - [x] A matrix of Server/Zero builds with GCC 10

This pull request has now been integrated.

Changeset: ee365d75
Author:    Aleksey Shipilev <sh...@openjdk.org>
URL:       
https://git.openjdk.org/jdk/commit/ee365d75cca6f33e5781fe514e557caba2b67c32
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8336342: Fix known X11 library locations in sysroot

Reviewed-by: jwaters, phh, prr

-------------

PR: https://git.openjdk.org/jdk/pull/20170

Reply via email to