On Mon, 5 Aug 2024 12:47:52 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update html > > doc/building.md line 1816: > >> 1814: The only directories required to have short paths are `Microsoft >> Visual Studio` >> 1815: and `Windows Kits`; the rest of the "contains space" warnings from >> `configure` >> 1816: can be ignored. You can choose any short name; once it is set, >> `configure`'s > > What other directories are reported from configure? > > It does not seem correct to me to say that they can just be ignored -- either > the directory is relevant for compilation, and then we need to have it > without spaces, or it is not really used and then it should be removed, or > made optional. > > If `Microsoft Visual Studio` and `Windows Kits` are typical > path-with-spaces that users can run into, we should perhaps add an additional > check to configure for these. In fact, I think what we *should* do is to have > configure print this help about `fsutil file setshortname` if it encounters a > path with spaces that it cannot turn into a short name. That way, a complete > copy/pastable command line can be generated for the user to run. configure scans `PATH` which may include other spaced directories, such as "Intellij Idea." On a user device, this list can quickly become huge and it would be unrealistic for users to generate short paths for every single one of those directories. In fact, the only 2 directories that need short path configuration for configure to work correctly are Microsoft Visual Studio and Windows Kits. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20197#discussion_r1704333632
