On Thu, 29 Aug 2024 09:02:36 GMT, Magnus Ihse Bursie <[email protected]> wrote:
> The indentation in the build system should be two spaces for logical indents, > and four spaces for broken lines, period. > > I searched for files starting with an odd number of spaces, and fixed those. Thanks for fixing this! See two nits. Also for anyone wondering, we defined these conventions for the build system a long time ago: https://openjdk.org/groups/build/doc/code-conventions.html make/CompileJavaModules.gmk line 78: > 76: CreateHkTargets = \ > 77: $(call FilterExcludedTranslations, \ > 78: $(patsubst $(TOPDIR)/src/%, $(JDK_OUTPUTDIR)/modules/%, \ Isn't this a continuation? make/autoconf/boot-jdk.m4 line 609: > 607: BUILD_JDK_FOUND=maybe > 608: AC_MSG_NOTICE([Found potential Build JDK using configure > arguments]) > 609: fi And here? ------------- PR Review: https://git.openjdk.org/jdk/pull/20763#pullrequestreview-2268621402 PR Review Comment: https://git.openjdk.org/jdk/pull/20763#discussion_r1736133668 PR Review Comment: https://git.openjdk.org/jdk/pull/20763#discussion_r1736134938
