On Mon, 2 Sep 2024 12:28:17 GMT, Magnus Ihse Bursie <[email protected]> wrote:

> From the bug report:
> 
> Users are reporting warnings like this:
> 
> lib/CompileGtest.gmk:84: warning: overriding recipe for target 
> '/.../build/linux-x64/make-support/compile-commands/jvm-ldflags.txt'
> lib/CompileJvm.gmk:166: warning: ignoring old recipe for target 
> '/.../build/linux-x64/make-support/compile-commands/jvm-ldflags.txt'
> 
> I believe this is caused by 
> [JDK-8338290](https://bugs.openjdk.org/browse/JDK-8338290), where the 
> jvm-ldflags.txt target file isn't made unique enough.

Looks trivial and good, but I can't quite tell if this introduces a new 
parameter to SetupNativeCompilation (It's been a while since I've worked on the 
JDK's build system). Does it?

-------------

Marked as reviewed by jwaters (Committer).

PR Review: https://git.openjdk.org/jdk/pull/20819#pullrequestreview-2275544664

Reply via email to