On Thu, 5 Sep 2024 13:23:14 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Marked as reviewed by erikj (Reviewer). > >> @erikj79 : Please take a look. Thanks. > >> Maybe @erikj79 ? Thanks. > > I generally skip most GHA related PRs as there are plenty of other reviewers > on this mailing list with deeper GHA knowledge than I have, and it's not a > focus for my current role at my employer. This patch was however small enough > so I was comfortable approving it. > > Tagging me, or someone else, specifically in a PR, requesting a review with > the intent of getting it quicker, will likely just have the opposite effect > as it may deter other people from jumping in to review, thinking you already > have some kind of agreement with the person being tagged. @erikj79: Thanks for having a look. The reason why I tagged you is that I was thinking that you as a reviewer of the previous https://github.com/openjdk/jdk/pull/18435 might be more familar with the background of this GHA issue. But you are right. Apologies anyway :-) ------------- PR Comment: https://git.openjdk.org/jdk/pull/20853#issuecomment-2331727796
