On Mon, 16 Sep 2024 18:57:42 GMT, Stephen Colebourne <[email protected]>
wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> tz files aligned with the default TzdbZoneRulesProvider list
>
> make/jdk/src/classes/build/tools/tzdb/TzdbZoneRulesProvider.java line 308:
>
>> 306: if (off < tokens.length) {
>> 307: String dayRule = tokens[off++];
>> 308: if (dayRule.regionMatches(true, 0, "last", 0, 4)) {
>
> This isn't correct, as per the mailing list:
>
>> > can "last" contain uppercase letters, or
>> > does it have to be exactly "last"?
>>
>> In that case the name is "lastSunday", and it can be abbreviated
>> "lastSu" or "Lastsu" or "LASTSUNDA" or whatever.
Why is it not? IIUC, abbreviation should be unambiguous, so "last" part is
always case-insensitive 4 character length.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20940#discussion_r1761768765
