On Fri, 11 Oct 2024 12:54:42 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
>> Please review this change that adds a new test root `docs` dedicated to >> testing the documentation, which has been a work in progress for a while. >> Tests for links, encoding, HTML, accessibility will be later added in >> following PRs. >> >> We also define a new make target `test-docs` meant for local use and depends >> on the docs. >> This also adds the necessary configurations needed at Oracle. >> >> This patch includes a test `TestDocs` which serves to show developers how >> they are meant to resolve the docs to test them, I want to include it >> temporarily until better tests are added later. >> >> TIA > > Nizar Benalla has updated the pull request incrementally with one additional > commit since the last revision: > > Add tidy as a dependency to `run-test-prebuilt-docs` and `docs` profiles test/docs/ProblemList.txt line 3: > 1: # > 2: # Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved. > 3: # ORACLE PROPRIETARY/CONFIDENTIAL. Use is subject to license terms. Please change this to the standard GPL header. test/docs/TEST.ROOT line 1: > 1: # This file identifies the root of the test-suite hierarchy. This file should have a standard copyright header, too. I see now that the existing TEST.ROOT in jdk, langtools and jaxp is also missing this header. If you want, you can add it to them in this PR too, or we'll open a separate issue for that. But in any case this new file needs a proper header. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21272#discussion_r1797083016 PR Review Comment: https://git.openjdk.org/jdk/pull/21272#discussion_r1797085750
