On Wed, 16 Oct 2024 13:02:52 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
>> Can I get a review for this patch that adds the necessary changes for local >> support of the `tidy` library. >> >> The dependency can be retrieved by running `make/devkit/createTidyBundle.sh` >> on Linux and MacOs systems. >> >> This dependency is primarily going to be used to test the generated >> documentation. >> >> This patch is meant to be integrated before #21272. >> >> Note: we need to be a very specific revision of `tidy` and cannot use any of >> the available artifacts, as older versions do not recognize some HTML 5 >> elements. >> >> TIA > > Nizar Benalla has updated the pull request incrementally with one additional > commit since the last revision: > > revert changes to RunTestsPrebuiltSpec.gmk make/autoconf/lib-tests.m4 line 330: > 328: AC_MSG_RESULT([yes]) > 329: AC_MSG_CHECKING([for tidy version]) > 330: TIDY_VERSION=`$ECHO $tidy_output | $SED -e 's/.*version //g'` Looks like `TIDY_VERSION` isn't "exported", should it be lower-case? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21341#discussion_r1803624439
