On Fri, 18 Oct 2024 18:23:13 GMT, Johan Vos <[email protected]> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Don't hardcode server variant
>
> src/java.base/unix/native/libjli/java_md.c line 279:
>
>> 277: char jvmpath[], jint so_jvmpath,
>> 278: char jvmcfg[], jint so_jvmcfg) {
>> 279: /* Compute/set the name of the executable. This is needed for
>> macOS. */
>
> But this file is not used when on macOS, is it? (cfr java_md_macosx.m) )
Hm. I think both are used? I'll need to double-check that.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1808787882
