On Thu, 31 Oct 2024 09:42:54 GMT, Doug Simon <[email protected]> wrote:
> There have been numerous problems in the past with the logic for removing > bundles: > > * [JDK-8340418](https://bugs.openjdk.org/browse/JDK-8340418) > * [JDK-8336928](https://bugs.openjdk.org/browse/JDK-8336928) > * [JDK-8338402](https://bugs.openjdk.org/browse/JDK-8338402) > > These problems can be avoided by relying on the [built-in GHA mechanism for > specifying a retention > limit](https://docs.github.com/en/organizations/managing-organization-settings/configuring-the-retention-period-for-github-actions-artifacts-and-logs-in-your-organization) > for these bundles. This PR deletes the code that eagerly removes the bundles > prior to the retention limit. > > An additional benefit to preserving the artifacts longer is that it increases > the window for being able to download them for extra testing under different > configurations than those tested by GHA (e.g. same test, different GC flags). Marked as reviewed by shade (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/21801#pullrequestreview-2408014492
