On Wed, 13 Nov 2024 22:56:47 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
> I was not successful in writing a test to check to return value of `make > help`, but this patch should fix the current bug. > > > % make help >/dev/null; echo $? > > 0 > % make help > > OpenJDK Makefile help > ===================== > > Common make targets > make [default] # Compile all modules and create a runnable "exploded" > # image (alias for jdk or exploded-image) > make all # Create all images: product, test, docs > # (alias for all-images) > make images # Create a complete jdk image > # (alias for product-images) > make <name>-image # Build just the image for any of: > # jdk, test, docs, symbols, legacy-jre, static-libs > make <phase> # Build the specified phase and everything it depends > on > # (gensrc, java, copy, libs, launchers, gendata) > make *-only # Applies to most targets and disables building the > # dependencies for that target. This is faster but may > # result in incorrect build results! > make docs # Create all docs > make docs-jdk-api # Create just JDK javadocs > make bootcycle-images # Build images twice, second time with newly built JDK > make check # Run basic testing (currently tier1) > make test-<test> # Run test, e.g. test-tier1 > make test TEST=<t> # Run test(s) given by TEST specification > make exploded-test TEST=<t> # Run test(s) on the exploded image instead of > # the full jdk image > > Targets for troubleshooting > make help # Give some help on using make > make doctor # Diagnose build environment problems > make reconfigure # Rerun configure with the same arguments as last time > > Targets for cleaning > make clean # Remove all files generated by make, but not those > # generated by configure > make dist-clean # Remove all files, including configuration > make clean-<outputdir> # Remove the subdir in the output dir with the name > make clean-<phase> # Remove all build results related to a certain build > # phase (gensrc, java, libs, launchers) > make clean-<module> # Remove all build results related to a certain module > make clean-<module>-<phase> # Remove all build results related to a certain > # module an... Not a make expert; but matching parens seems like a winner. ------------- Marked as reviewed by rriggs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22089#pullrequestreview-2434887088
