On Mon, 18 Nov 2024 10:06:05 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

> Some makefiles include JavaCompilation.gmk when they really want to include 
> ZipArchive.gmk. (Currently, JavaCompilation.gmk includes ZipArchive.gmk 
> indirectly to keep backwards compatibility from when these were implemented 
> in the same file.)
> 
> Also, all files that calls SetupJarArchive should include JarArchive.gmk 
> directly.

Looks reasonable, thanks.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22194#pullrequestreview-2442360819

Reply via email to