On Thu, 21 Nov 2024 20:58:59 GMT, Phil Race <p...@openjdk.org> wrote:

>> This fix deprecates for removal java.awt.Window.getWarningString() and also 
>> javax.swing.JInternalFrame.getWarningString()
>> l java.awt.Window.getWarningString() is only relevant with a SecurityManager 
>> and javax.swing.JInternalFrame.getWarningString() is just there for symmetry.
>> 
>> A few other spec changes ensue - the serial form variable warningString is 
>> removed is the main one.
>> The AWTPermission showWindowWithoutWarningBanner is obsolete
>> Reference to the system property  "awt.appletWarning" was actually already 
>> removed by JEP 486
>> 
>> There is a CSR for the spec. changes, which will need a reviewer : 
>> https://bugs.openjdk.org/browse/JDK-8344451
>> 
>> But the vast majority of the changes here are all the downstream obsoleted 
>> implementation
>> The warning string and warning icon, and warning windows are all obsoleted.
>> I think I tracked down all of it, but it is hard to be sure.
>> Automated tests are passing, and I've manually tested SwingSet2 on all 3 
>> platforms.
>
> Phil Race has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   8342903

Marked as reviewed by azvegint (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22221#pullrequestreview-2452779527

Reply via email to