On Thu, 5 Dec 2024 09:55:28 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
> After [JDK-8339480](https://bugs.openjdk.org/browse/JDK-8339480), tier5 tests > started failing in the `special:make:all` test. The culprit turned out to be > that FindDebuginfoFiles was added to FileUtils.gmk, causing the find cache to > be populated when it shouldn't be. > > As a simple fix I am moving FindDebuginfoFiles into a separate file. The > `DebugInfoUtils.gmk` is a bit odd since it is so specialized, and only shared > among two files, but I could find no better way. The code is still a bit too > complex to be duplicated, and I could not find any other place where it would > belong better. The handling of debuginfo files is a bit spread out in the > code base, so maybe this opens up for the chance to consolidate more > debuginfo handling into this file further on. Marked as reviewed by erikj (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/22569#pullrequestreview-2481788124
