On Fri, 6 Dec 2024 08:14:31 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> I saw this too late, shouldn't it be isTargetOs instead of isBuildOs? Or am >> I mistaken and only gtest is affected, hence isBuildOs? Actually I'm not >> sure which one would be appropriate for gtest > > I think in the AIX case the target and build OS is always the same so it > should be okay as it is. > isTargetOs might generally fit better. So currently we do not allow for cross-OS compilation. (This might change in the future.) So in practice, target OS and build OS is the same, and we might have been sloppy elsewhere. But you are correct Julian that this would have been better. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22412#discussion_r1872818602
