On Sat, 7 Dec 2024 13:49:34 GMT, Alan Bateman <[email protected]> wrote:
>> Alexandre Iline has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed a trailing space
>
> make/conf/jib-profiles.js line 1210:
>
>> 1208: file: "bundles/jcov-3.0+1.zip",
>> 1209: environment_name: "JCOV_HOME",
>> 1210: configure_args: "--with-jcov=" + input.get("jcov",
>> "home_path"),
>
> I tried it, and it works for me, thank you! Note there's a space after
> `"JCOV_HOME", ` that you might want to remove.
Actually, when I took a second look, I realize the `configure_args` argument is
probably not needed, since it should be default. Can you check if it works
without it?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22625#discussion_r1876246837
