On Fri, 13 Dec 2024 04:06:47 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> As requested in [SKARA-1357](https://bugs.openjdk.org/browse/SKARA-1357), >> now skara bot is able to check the copyright header format. >> Now I am going to update the jcheck configuration to configure copyright >> check as an error. > > .jcheck/conf line 39: > >> 37: >> 38: [checks "copyright"] >> 39: >> files=^(?!LICENSE|license\.txt|.*\.bin|.*\.gif|.*\.jpg|.*\.png|.*\.patch|.*\.wav|.*\.class|.*-header|.*\.jar|).* > > IIUC there are other special files that could be excluded here: .icon, .tiff, > .dat > > But, again IIUC, this is just an optimization as the check would be "if the > file has what appears to be an Oracle copyright, then validate the format". > So binary files would not have it and so would not be validated. Yes, your understanding is correct. Additionally, Skara won't attempt to check binary files. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22721#discussion_r1884233125
