On Fri, 17 Jan 2025 06:05:54 GMT, David Holmes <dhol...@openjdk.org> wrote:
> Do the gtest changes not require something in > make/hotspot/lib/CompileGtest.gmk? I don't see anything obvious that needs to be changed. I've verified that turning precompiled headers on adds the correct flags for gtests and that gtestMain.cpp gets compiled without precompiled headers (as requested in the make file). > > Otherwise as long as this works it seems fine. (I presume the necessary > compilers didn't support this when we made the original switch from > includeDB.) ... or no one involved in that changed figured out that this was a possibility. > > I expect there are copyrights that need updating (though not too many once > Coleen has finished with her changes :) ). Right. As long as we should update the copyrights even if we just remove code ... Thanks for reviewing! ------------- PR Comment: https://git.openjdk.org/jdk/pull/23146#issuecomment-2597664562
