On Tue, 21 Jan 2025 15:08:39 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
> This part looks dangling now: > > ``` > * precompiled.hpp is just a build time optimization, so don't rely on > it to resolve include problems. > ``` > > Maybe move the line at the end of the list and phrase it as: > > "* Consider adding the frequently used header includes to precompiled.hpp. > This can improve build times, but the improvement needs to be validated. > precompiled.hpp is just a build time optimization, so don't rely on it to > resolve include problems." Right. I thought that the statement was still valid but I agree that it can be odd without more context. I'm don't want to encourage people to add stuff to the precompiled.hpp. Maybe something like this: * Some build configurations uses precompiled headers to speed up the build times. The compiled headers are included in the precompiled.hpp file. Note that precompiled.hpp is just a build time optimization, so don't rely on it to resolve include problems. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23210#issuecomment-2605111660
