On Tue, 21 Jan 2025 13:56:41 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> After JDK-8347825, `test:idea` started failing in the Oracle CI. >> >> The problem is that when running in the Oracle CI, we are passing >> `CONF_NAME` to the topmost make. This will result in both `CONF_NAME` and >> `SPEC` being defined when making the nested make call in the idea.sh script, >> and this is not allowed. >> >> I solved this the proper way, by unexporting the variables we have setup >> during make that could interfere. > > test/make/TestIdea.gmk line 32: > >> 30: >> 31: # Enable the shell script to call make without us interfering. >> 32: # We will keep the $(SPEC), though, to find back to our configuration. > > This comment confuses me. Why do we need to keep `SPEC` defined? This is so that when `idea.sh` finally calls make again, we will get back to our configuration. Otherwise, if we have multiple configurations, `idea.sh` will fail since it can't single out a specific one. This will not show up on CI runs where we only have a single configuration, but can arise when running the test locally with several configurations. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23200#discussion_r1924043452
