On Thu, 23 Jan 2025 10:14:24 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

> To figure out the root of the JDK build, we set the TOPDIR variable in 
> configure. Furthermore, we clean it up using UTIL_FIXUP_PATH as we do with 
> all paths. On Windows, this can result in the path becoming all lowercase. 
> Since Windows paths are case insensitive, this is normally not a problem. 
> However, we try to strip the TOPDIR from paths in several locations like this:
> 
> 
> $$(subst $$(TOPDIR)/, , $$($1_TEST_RESULTS_DIR))
> 
> 
> and that will only work if the case actually matches.

Will this also fix the issue with case insensitive paths on Mac, where if the 
$PWD value has a different case than the actual path to the workspace root, we 
fail to recognize that it's the workspace root?

-------------

Marked as reviewed by erikj (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23259#pullrequestreview-2569925693

Reply via email to