On Wed, 29 Jan 2025 11:47:23 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> following Magnus proposals
>
> make/autoconf/basic.m4 line 630:
>
>> 628: # Copy the linker wrapper script for AIX' clang and make it executable
>> 629: if test "x$TOOLCHAIN_TYPE" = xclang && test "x$OPENJDK_TARGET_OS" =
>> xaix &&
>> 630: test -e "${TOPDIR}/make/scripts/aix/ld.sh"; then
>
> You can assume that checked-in files exist and do not need to test for them.
Done
> make/autoconf/basic.m4 line 631:
>
>> 629: if test "x$TOOLCHAIN_TYPE" = xclang && test "x$OPENJDK_TARGET_OS" =
>> xaix &&
>> 630: test -e "${TOPDIR}/make/scripts/aix/ld.sh"; then
>> 631: $CP -f "${TOPDIR}/make/scripts/aix/ld.sh" "$OUTPUTDIR/ld.sh"
>
> Suggestion:
>
> $CP -f "$TOPDIR/make/scripts/aix/ld.sh" "$OUTPUTDIR/ld.sh"
>
>
> We normally prefer to use $ without {} unless they are necessary, but in some
> parts of the code the ${} style is prevalent for historical reasons, and in
> those places it is better to keep with that style. But for code like this,
> you should stick to the {}-less style.
Done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23313#discussion_r1933778459
PR Review Comment: https://git.openjdk.org/jdk/pull/23313#discussion_r1933778671
