On Fri, 31 Jan 2025 14:14:45 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

>> A make variable like 
>> `JTREG="JAVA_OPTIONS=-Djava.security.debug=all;MAX_OUTPUT=1000000"` could 
>> end up losing the quotes and thus the shell will split at `;` in 
>> reinvocations of make. For the `JTREG` variable specifically, this is a 
>> regression since [JDK-8348586](https://bugs.openjdk.org/browse/JDK-8348586), 
>> that moved `JTREG` from `INIT_CONTROL_VARIABLES` to 
>> `MAKE_CONTROL_VARIABLES`, which were not properly treated.
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to 
> a merge or a rebase. The pull request now contains four commits:
> 
>  - Remove extra line
>  - Indentation got wrong during merge
>  - Merge branch 'master' into fix-control-variables
>  - 8349143: All make control variables need special propagation

Marked as reviewed by erikj (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/23389#pullrequestreview-2586936283

Reply via email to