On Wed, 12 Feb 2025 19:49:42 GMT, Zhao Song <zs...@openjdk.org> wrote:
> The copyright header format check was introduced in > [JDK-8346046](https://bugs.openjdk.org/browse/JDK-8346046). However, a user > recently reported that the check doesn't catch incorrect copyright headers in > this pr(https://github.com/openjdk/jdk/pull/23550). > > After investigation, I found that the issue was caused by the file regex in > .jcheck/conf. There is a redundant "|" character after ".*.jar". > > `files=^(?!LICENSE|license.txt|.*.bin|.*.gif|.*.jpg|.*.png|.*.icon|.*.tiff|.*.dat|.*.patch|.*.wav|.*.class|.*-header|.*.jar|).*` > > This redundant "|" prevents the regex from matching any string. I have tested it in playground https://github.com/openjdk/playground/pull/224 Here is the .jcheck/conf https://github.com/openjdk/playground/blob/testSKARA/.jcheck/conf ------------- PR Comment: https://git.openjdk.org/jdk/pull/23598#issuecomment-2654706707
