On Wed, 19 Feb 2025 16:05:15 GMT, Nizar Benalla <nbena...@openjdk.org> wrote:
>> This patch fixes a regression where the windows tools man pages appeared on >> the Linux and the MacOS builds >> >> The man pages found using `FindModuleManDirs` were used in both `Docs.gmk` >> used to generate the documentation for the JDK as well as in >> `LauncherCommon.gmk` here >> https://github.com/openjdk/jdk/blob/efbad00c4d7931177ccc5e9bce3b30dfbac94010/make/common/modules/LauncherCommon.gmk#L195 >> >> I've separated the logic between generated the docs and the man pages. I've >> checked on a MacOs machine and the man pages no longer appear. >> >> This patch will need to be backported to JDK 24. > > Nizar Benalla has updated the pull request incrementally with one additional > commit since the last revision: > > respond to feedback Marked as reviewed by erikj (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/23697#pullrequestreview-2627542351
