On Wed, 19 Feb 2025 08:02:07 GMT, Claes Redestad <redes...@openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Use SetupCopyFiles macro to copy the dependency files
>
> If you have manually verified that the build fails if any of these files are 
> removed then I'm happy. No new tests or documentation needed, really. 
> 
> I could cast my vote towards removing these particular micros. But as the 
> work is done I say let's accept your change, (re-)evaluate their usefulness, 
> and file a RFE to have them removed if they aren't. We have been building out 
> the set of micros we regularly test in nightly / promotion testing, but due 
> to resource constraints only a fraction is run on a regular basis - and 
> javax.xml has not been a priority.

Thanks @cl4es @erikj79 for the suggestions and reviews.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23625#issuecomment-2670335704

Reply via email to