On Fri, 21 Feb 2025 10:15:12 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org>
wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review remarks, dates, some more simplifications
>
> src/java.base/share/classes/java/lang/invoke/X-VarHandleSegmentView.java.template
> line 85:
>
>> 83:
>> 84: @ForceInline
>> 85: static $type$ get(VarHandle ob, Object obb, long base) {
>
> I like this: a fast path for non-strided access, while, at the same time,
> reusing the impl.
> In the future we can also add another variant for when there's only one index
> (which is by far the most common case).
I think that would require new impl classes, as there may be invocation type
clash with the existing one-offset version. And the new offset will require
extra checks too.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23720#discussion_r1968135651
