On Fri, 21 Feb 2025 14:24:22 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> Noticed this when reviewing >> [JDK-8349399](https://bugs.openjdk.org/browse/JDK-8349399), which had to >> kludgy workaround the hunk introduced by `static-libs-bundles` addition >> ([JDK-8337265](https://bugs.openjdk.org/browse/JDK-8337265)). I am somewhat >> surprised we even have `static-libs-bundles` as additional target in what I >> would consider a generic build-linux job! It looks cleaner to yank >> `static-libs-bundles` into a separate build job. >> >> This effectively reverts parts of the original change, and does a few >> modifications: >> - I see no reason to store the bundles, and continuing to do so would >> effectively overwrite `linux-x64-bundles` when we split the static build >> into another job, breaking tests. Not sure why we had to publish those >> bundles, @dougxc? They are not used in current JDK tests, I think? >> - The matrix definition in `build-linux.xml` unconditionally includes >> `debug` configuration to override flags and suffix, I had to redo this with >> inline variables >> >> Named the new job `linux-x64-static`, since I expect @jianglizhou to slide >> https://github.com/openjdk/jdk/pull/23471 just there by adding another >> `make-target` into that job definition. >> >> I did a partial GHA run already, and I expect full run to complete without >> errors. >> >> Testing: >> - [x] GHA > > Aleksey Shipilev has updated the pull request incrementally with one > additional commit since the last revision: > > Rename -static job to -static-libs I think this is good. The static libs situation is somewhat messy due to historical reasons, and it is not always easy to know what is the best improvement, in the short term or in the long term. I would like to remove the old `static-libs` target and replace it with the new `static-jdk-image`, but we're not there yet. In the meantime, I think it makes sense to separate it out cleanly as you have done here. ------------- Marked as reviewed by ihse (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23715#pullrequestreview-2641598006
