On Wed, 26 Feb 2025 17:52:57 GMT, Jiangli Zhou <jian...@openjdk.org> wrote:
>> Please review this change that adds a `linux-x86-static` job in GHA. The job >> builds the `static-jdk-image` release binary on linux-x64. Please see >> https://mail.openjdk.org/pipermail/build-dev/2025-February/048830.html for >> some additional context. >> >> A `debug` build job (building `static-jdk-image` fastdebug binary) is not >> included currently. There is a known issue that causes build failure due to >> resource problem, which causes the `fastdebug` build fail in github >> workflow. Please see more related information in >> https://bugs.openjdk.org/browse/JDK-8349399?focusedId=14749789&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14749789. >> >> >> GHA: https://github.com/jianglizhou/jdk/actions/runs/13163673020 > > Jiangli Zhou has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains nine additional > commits since the last revision: > > - Rename build-linux-x64-static job to build-linux-x64-static-jdk. Remove > build-linux-static.yml. > - Merge branch 'master' into JDK-8349399 > - Set matrix. > - Remove debug build for now. > - Set debug-levels to "release". > - Set debug-levels to "debug". > - Add build-linux-static.yml. > - Add build-linux-static.yml. > - Add build-linux-x64-static build job in GHA. Cool, one nit: .github/workflows/main.yml line 171: > 169: if: needs.prepare.outputs.linux-x64 == 'true' > 170: > 171: build-linux-x64-static-jdk: Move this closer to `build-linux-x64-static-libs`? These are somewhat related, at least in their need for `debug-levels: release`. Probably copy a comment about debug-level there. ------------- PR Review: https://git.openjdk.org/jdk/pull/23471#pullrequestreview-2645368779 PR Review Comment: https://git.openjdk.org/jdk/pull/23471#discussion_r1972091928
