On Wed, 5 Mar 2025 22:59:06 GMT, Jiangli Zhou <jian...@openjdk.org> wrote:
> Please review this PR that excludes `libjsig` from being statically linked > with `static-jdk` `java` launcher by default. Please see details in > https://bugs.openjdk.org/browse/JDK-8351309 description and comments. Thanks It seems we agree that we need, at some point, to have a high-level discussion on if libjsig should be supported on static builds, and if so, how it should be implemented. We also agree that having signal chaining enabled by default on our static JDK builds are incorrect. However, I suggest we chose a simple path, were we utilize the framework for not building a static library that we do not use (this is already done for several libraries that are not included in the static JDK image), while you suggest we keep compiling it, even if we do not include it and test it. I don't get the point of this. If we don't include it, and don't test it, then surely it would be better to not even build it now? ------------- PR Comment: https://git.openjdk.org/jdk/pull/23924#issuecomment-2704857060
