On Tue, 18 Mar 2025 13:12:16 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> make/modules/java.base/Copy.gmk line 128: >> >>> 126: $(foreach import_jvm, $(IMPORT_JVM_NAMES), \ >>> 127: $(eval $(import_jvm)_path := $(patsubst $(import_jvm):%,%,$(filter >>> $(import_jvm):%, $(IMPORT_JVMS)))) \ >>> 128: $(eval $(call MakeDir, $(LIB_DST_DIR)/$(import_jvm))) \ >> >> Do you really need to call MakeDir outside of a recipe? Won't SetupCopyFiles >> recipes create this directory? > > I assumed it would, but it failed, and I looked at the code and found no > clear evidence that it does, so I added this. It might have been some other > issue, so I can double-check again, if you are certain that SetupCopyFiles > should create needed directories. SetupCopyFiles uses `install-file` by default and that macro calls `MakeTargetDir`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24063#discussion_r2001341907
