On Mon, 7 Apr 2025 07:08:51 GMT, David Linus Briemann <d...@openjdk.org> wrote:
> * How does it conflict with the jcheck rules? The rules defined in this > editorconfig are stricter than the jcheck rules. So jcheck could not find > issues after the editorconfig rules were applied. No, it's not. The rules you propose here are stricter. You say: [*] trim_trailing_whitespace = true but there is not nor have ever been such a rule for all text files in the JDK repo. This would trigger an enormous amount of spurious changes. In contrast, my suggested PR applies this only to the subset of files where we do in fact have a rule of no trailing whitespaces. > I also would ask about `jcheck`. Where and how is it used. The only > information I found are: > https://openjdk.org/projects/code-tools/jcheck/ and the config file in > `jdk/.jcheck`. jcheck is run automatically by the Skara bots on all PRs. If jcheck reports an error (that is, a violation of enforced style rules), the PR will not be possible to integrate. Users can also run jcheck locally using the `git skara jcheck` command, if they have the Skara git tools installed. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23693#issuecomment-2782776621
