On Fri, 4 Apr 2025 14:32:30 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> We have been sloppy in our use of `printf` in make code. Most of the time, >> we should really use `echo` instead. If we do need to use `printf`, we >> should never inline make or shell variables into the formatting string, >> since they may contain `%` which will be interpreted as formatting. Instead, >> we should always use `%s` and pass the variable as an argument to `printf`. >> >> I've checked the entire code base for usages of $PRINTF, and converted most >> of them to $ECHO, and made sure the remaining ones are correct. I also >> discovered some additional ugly stuff in relation to this, which I fixed. > > Magnus Ihse Bursie has updated the pull request incrementally with one > additional commit since the last revision: > > echo do not need escaped quotes Marked as reviewed by erikj (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/24415#pullrequestreview-2746959037
