On Mon, 7 Apr 2025 14:05:47 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> We had a test setup failure in our distributed test system where the process >> running jtreg crashed. This caused the hs_err file to end up in the root of >> the source tree. Dropping crash files in the source tree is bad practice and >> makes it harder to find such files. We should change the current working >> directory to the work/output dir before launching jtreg to help avoid this >> situation in the future. > > make/RunTests.gmk line 1000: > >> 998: $1_COMMAND_LINE := \ >> 999: cd $$($1_TEST_SUPPORT_DIR) && $$(JTREG_JAVA) \ >> 1000: $$($1_JTREG_LAUNCHER_OPTIONS) \ > > Should this be aligned with the row below? I didn't notice that. Actually, I think it is the remaining lines that are incorrectly indented. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24452#discussion_r2031968148
