On Tue, 8 Apr 2025 18:08:57 GMT, Chen Liang <li...@openjdk.org> wrote:
>> The else block generates the closing tag for the note. As you see in the PR >> description, the tag syntax resembles HTML open/close tags. This is a >> compromise to be able to locate the note within the description (which isn't >> possible with block tags), and being able to use rich content in the note >> without being required to writing a dedicated tag parser and rendering code. >> (I also happen to find this syntax easier to read than a custom inline tag, >> which would require additional rules to separate meta data from note >> content.) > > Such usage should be reflected in `testPreviewNoteTag`, which currently does > not use it as open/close tags. The problem is the Taglet class is part of the build system, and I don't think we have a way to test these build classes (I coulndn't find any tests for the other build Taglets). I could replicate the Taglet class in the test, but that doesn't seem like a good solution either. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23395#discussion_r2033795505
