On Tue, 8 Apr 2025 20:33:33 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Migrates the CreateSymbols tool to use the ClassFile API, away from >> com.sun.tools.classfile. >> >> Need the boot jdk `--with-boot-jdk=` to be 24; thus a draft for now; but >> this is open to reviews. >> >> Together with #24206, the old com.sun.tools.classfile can be removed from >> the JDK. > > Chen Liang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains six additional commits since > the last revision: > > - Merge branch 'master' of https://github.com/openjdk/jdk into > feature/migrate-create-symbols > - Merge branch 'master' of https://github.com/openjdk/jdk into > feature/migrate-create-symbols > - Other references to remove > - Merge branch 'master' of https://github.com/openjdk/jdk into > feature/migrate-create-symbols > - FieldDescription.constantValue uses Integer for byte and short > - 8310310: Migrate CreateSymbols tool in make/langtools to Classfile API I skimmed through the `CreateSymbols` changes, used `test/langtools/tools/javac/sym/PrintCTSymContent.java` to print ct.sym content before and after, and let the tool that generates the `.sym.txt` to run for JDK 24. All seems fine to me. Thanks! ------------- Marked as reviewed by jlahoda (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/24212#pullrequestreview-2753708018
