On Tue, 27 May 2025 20:48:13 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> After [JDK-8292944](https://bugs.openjdk.org/browse/JDK-8292944), we only >> generate module-deps.gmk once at the start of Init.gmk. This causes `make >> clean <some other target>` to first generate and then remove module-deps.gmk >> after which the rest of the build proceeds without a module-deps.gmk, >> causing problems with dependencies. > > Magnus Ihse Bursie has updated the pull request with a new target base due to > a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - Fix it for real > - Merge branch 'master' into fix-clean-module-deps > - 8349665: Make clean removes module-deps.gmk Well it works, but causes a regression of JDK-8292944 ("make help" as the first target after configure). *sigh* It turns out there had already been a partial regression of JDK-8292944 by JDK-8349515... This is now fixed as well. Third time's a charm! Now this should really, really work. (And we should really, really have a regression testing framework for the build system ðŸ˜). ------------- PR Comment: https://git.openjdk.org/jdk/pull/24406#issuecomment-2914017583 PR Comment: https://git.openjdk.org/jdk/pull/24406#issuecomment-2914060430
