On Tue, 8 Jul 2025 21:03:40 GMT, Mikael Vidstedt <mik...@openjdk.org> wrote:
> Sorry for the potentially stupid question but: what happens if the pattern > spans a chunk? Thanks for catching that! I should've been more careful. Rewrote the byte matching completely to accommodate, but now test takes twice as long... also new scan function operates under assumption that no non-printable ascii bytes within searchPatterns. I profiled the new test but nothing obvious at why the new function takes longer... (I suppose reading single byte at a time is bad, but I assumed a buffered stream would negate that). I'll do more debugging; I tried converting the patterns to strings thinking using library string matching algorithm might be an improvement, but that didn't yield improvements on my local unfortunately. ------------- PR Comment: https://git.openjdk.org/jdk/pull/26030#issuecomment-3054308558
