On Sun, 10 Aug 2025 06:09:00 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:

>> The fix added JVMTI stress testing mode.
>> 
>> This mode enables stress agent that could be executed with jtreg test and 
>> help to ensure that jvmti functionality doesn't break the other JVM/JDK 
>> functionality.
>> 
>> I filed few issues and more are coming. I want to push the agent so it is 
>> possible to provide reproduces for problems uncovered by this agent.
>> 
>> The agent has 2 modes now:
>>  - regular that is compatible with most of tests including other jvmti, jdi 
>> and jdb tests
>>  - debugger, that additionally test some function requiring  solo 
>> capabilities and not compatible with debugger and some jvmti  tests 
>> 
>> The tests incompatible wiht agent (IR, CDS) and some individual tests from 
>> tier1 are excluded. There are not plans to support stable execution of all 
>> tests with agent right now. However it provokes some crashes worth to be 
>> used for exploratory testing.
>> Note, that flagless tests are excluded automatically and not executed in 
>> this mode.
>
> Leonid Mesnik has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   fixed makefiles

make/RunTests.gmk line 881:

> 879: 
> 880:   ifneq ($$(JTREG_JVMTI_STRESS_AGENT), )
> 881:     AGENT := 
> $$(LIBRARY_PREFIX)JvmtiStressAgent$$(SHARED_LIBRARY_SUFFIX)=$$(JTREG_JVMTI_STRESS_AGENT)

I don't understand the usage scenario here. Are you supposed to run this like 
`make test JTREG=JVMTI_STRESS_AGENT=true`? If so, this will result in 
`-javaoption:'-agentpath:<test-image>/hotspot/jtreg/native/libJvmtiStressAgent.so=true`
 being sent to jtreg, and that looks sus. 

Or how should this be used? 

In fact, this option should be described in testing.md.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26360#discussion_r2266155034

Reply via email to